616434 - Should be separating lines between the rows in the table of the details view

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[B.J. Herbison]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre
Build Identifier: 4.0b8pre (installed from nightly on 3 December 2010)

Looking at the details of an extension (clicking the "More" link), the table of information at the bottom is hard to parse because the first and second column can be very far apart.

The distance between the columns varies depending on the add-on, but in some cases it is almost 8 cm.

Reproducible: Always

Steps to Reproduce:
1. Purchase and install a monitor with a large horizontal resolution.
2. Run Firefox full-screen.
3. Install an add-on.
4. Open Add-ons Manager
5. Click "Extension" or "Appearance" as appropriate.
6. Click a "More" link.
7. Scroll to the bottom of the display.
Actual Results:  
There is a table at the bottom with rows labeled "Last Updates", "Automatic Updates", etc. The first and second columns are separated so widely it is hard to visually correlate the items in the first column with the second column,

Expected Results:  
There should be at most a couple of centimeters between the end of the first column and the start of the second column.

Comment 1

[B.J. Herbison]

Attachment: Screenshot showing the wide spacing.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

One possible solution would be to align it with the add-on description, which is shown above.

Comment 3

[Dave Townsend [:mossop]]

I think the biggest problem here is that there should be lines between the rows as there are on other platforms. Adding those would probably make it far easier to read the table.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like to be a Linux only bug. Other platforms have the lines.

But what about the horizontal space? Shouldn't have a better left-align of the values?

Comment 5

[B.J. Herbison]

I don't disagree that horizontal lines would be useful, but I still think it would be easier to read with less horizontal space between the columns. Does anyone think it looks better with that much white space?

Comment 6

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #5)
> I don't disagree that horizontal lines would be useful, but I still think it
> would be easier to read with less horizontal space between the columns. Does
> anyone think it looks better with that much white space?

Readability rather than whitespace is the problem.  Aligning information horizontally means headings (on the left) are easier to associate with their values (on the right).  Blair, can you add these lines?

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Turns out there were already lines, but they were just the same color as the background for some themes.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Landed: https://hg.mozilla.org/mozilla-central/rev/5c4d8d8417b8

I wouldn't bother with a litmus test for this one, since its just styling.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (X11; Linux i686; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre

Comment 10

[B.J. Herbison]

Yes, the table is easier to read with lines that are a different color from the background. However, I still think the text in the two columns are too far apart (on a wide, high-resolution screen). It's just plain ugly to have the white space between the columns be twice the width of the information displayed.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Can you please file a new bug? Thanks.